set_deparse_plan: Reuse variable to appease Coverity

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: e70813fbc4aaca35ec012d5a426706bd54e4acab
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2022-04-20T09:44:08Z
Releases: 15.0
set_deparse_plan: Reuse variable to appease Coverity

Coverity complains that dpns->outer_plan is deferenced (to obtain
->targetlist) when possibly NULL.  We can avoid this by using
dpns->outer_tlist instead, which was already obtained a few lines up.

The fact that we end up with
  dpns->inner_tlist = dpns->outer_tlist
is a bit suspicious-looking and maybe worthy of more investigation, but
I'll leave that for another day.

Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/202204191345.qerjy3kxi3eb@alvherre.pgsql

Files

PathChange+/−
src/backend/utils/adt/ruleutils.c modified +1 −1

Discussion