Revert "Allow parallel workers to cope with a newly-created session user ID."

Tom Lane <tgl@sss.pgh.pa.us>

Commit: e6a9637488e2673efb87f8ead657789e9889fb17
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2024-08-01T00:57:00Z
Releases: 18.0
Revert "Allow parallel workers to cope with a newly-created session user ID."

This reverts commit f5f30c22ed69fb37b896c4d4546b2ab823c3fd61.

Some buildfarm animals are failing with "cannot change
"client_encoding" during a parallel operation".  It looks like
assign_client_encoding is unhappy at being asked to roll back a
client_encoding setting after a parallel worker encounters a
failure.  There must be more to it though: why didn't I see this
during local testing?  In any case, it's clear that moving the
RestoreGUCState() call is not as side-effect-free as I thought.
Given that the bug f5f30c22e intended to fix has gone unreported
for years, it's not something that's urgent to fix; I'm not
willing to risk messing with it further with only days to our
next release wrap.

Files