Minor code rationalization: FlushRelationBuffers just returns void,
Tom Lane <tgl@sss.pgh.pa.us>
Minor code rationalization: FlushRelationBuffers just returns void, rather than an error code, and does elog(ERROR) not elog(WARNING) when it detects a problem. All callers were simply elog(ERROR)'ing on failure return anyway, and I find it hard to envision a caller that would not, so we may as well simplify the callers and produce the more useful error message directly.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/nbtree/nbtree.c | modified | +2 −6 |
| src/backend/catalog/heap.c | modified | +2 −5 |
| src/backend/catalog/index.c | modified | +2 −5 |
| src/backend/commands/cluster.c | modified | +3 −8 |
| src/backend/commands/vacuum.c | modified | +4 −10 |
| src/backend/commands/vacuumlazy.c | modified | +2 −4 |
| src/backend/storage/buffer/bufmgr.c | modified | +7 −24 |
| src/include/storage/bufmgr.h | modified | +2 −2 |