Code review for magic-block patch. Remove separate header file pgmagic.h,

Tom Lane <tgl@sss.pgh.pa.us>

Commit: e60cb3a35c88d33dbfc53afb91f5bfff4209dad0
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2006-05-30T21:21:30Z
Releases: 8.2.0
Code review for magic-block patch.  Remove separate header file pgmagic.h,
as this seems only likely to create headaches for module developers.  Put
the macro in the pre-existing fmgr.h file instead.  Avoid being too cute
about how many fields we can cram into a word, and avoid trying to fetch
from a library we've already unlinked.
Along the way, it occurred to me that the magic block really ought to be
'const' so it can be stored in the program text area.  Do the same for
the existing data blocks for PG_FUNCTION_INFO_V1 functions.

Files

PathChange+/−
doc/src/sgml/xfunc.sgml modified +24 −26
src/backend/utils/fmgr/dfmgr.c modified +45 −36
src/backend/utils/fmgr/fmgr.c modified +7 −7
src/include/fmgr.h modified +65 −6
src/include/pgmagic.h deleted +0 −73
src/test/regress/regress.c modified +5 −2