Improve coding of gistchoose and gistRelocateBuildBuffersOnSplit.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: e5db11c5582b469c04a11f217a0f32c827da5dd7
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-08-31T02:53:17Z
Releases: 9.3.0
Improve coding of gistchoose and gistRelocateBuildBuffersOnSplit.

This is mostly cosmetic, but it does eliminate a speculative portability
issue.  The previous coding ignored the fact that sum_grow could easily
overflow (in fact, it could be summing multiple IEEE float infinities).
On a platform where that didn't guarantee to produce a positive result,
the code would misbehave.  In any case, it was less than readable.

Files