Improve display of query results in isolation tests.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: e535a8899397841fa7c180ebd6517cf1bb76ef4c
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-06-23T15:12:32Z
Releases: 9.6.23
Improve display of query results in isolation tests.

Previously, isolationtester displayed SQL query results using some
ad-hoc code that clearly hadn't had much effort expended on it.
Field values longer than 14 characters weren't separated from
the next field, and usually caused misalignment of the columns
too.  Also there was no visual separation of a query's result
from subsequent isolationtester output.  This made test result
files confusing and hard to read.

To improve matters, let's use libpq's PQprint() function.  Although
that's long since unused by psql, it's still plenty good enough
for the purpose here.

Like 741d7f104, back-patch to all supported branches, so that this
isn't a stumbling block for back-patching isolation test changes.

Discussion: https://postgr.es/m/582362.1623798221@sss.pgh.pa.us

Files

PathChange+/−
contrib/test_decoding/expected/concurrent_ddl_dml.out modified +448 −288
contrib/test_decoding/expected/delayed_startup.out modified +26 −14
contrib/test_decoding/expected/mxact.out modified +52 −28
contrib/test_decoding/expected/oldest_xmin.out modified +20 −10
contrib/test_decoding/expected/ondisk_startup.out modified +37 −23
contrib/test_decoding/expected/snapshot_transfer.out modified +30 −18
contrib/test_decoding/expected/subxact_without_top.out modified +21 −11
src/test/isolation/expected/aborted-keyrevoke.out modified +112 −56
src/test/isolation/expected/alter-table-1.out modified +1370 −822
src/test/isolation/expected/alter-table-2.out modified +384 −192
src/test/isolation/expected/alter-table-3.out modified +192 −96
src/test/isolation/expected/alter-table-4.out modified +28 −14
src/test/isolation/expected/async-notify.out modified +32 −16
src/test/isolation/expected/classroom-scheduling.out modified +160 −80
src/test/isolation/expected/create-trigger.out modified +100 −50
src/test/isolation/expected/delete-abort-savept-2.out modified +48 −24
src/test/isolation/expected/delete-abort-savept.out modified +56 −28
src/test/isolation/expected/drop-index-concurrently-1_2.out modified +29 −17
src/test/isolation/expected/drop-index-concurrently-1.out modified +31 −19
src/test/isolation/expected/eval-plan-qual.out modified +97 −67
src/test/isolation/expected/eval-plan-qual-trigger.out modified +1061 −537
src/test/isolation/expected/freeze-the-dead.out modified +17 −9
src/test/isolation/expected/inherit-temp.out modified +156 −96
src/test/isolation/expected/insert-conflict-do-nothing-2.out modified +32 −16
src/test/isolation/expected/insert-conflict-do-nothing.out modified +8 −4
src/test/isolation/expected/insert-conflict-do-update-2.out modified +8 −4
src/test/isolation/expected/insert-conflict-do-update-3.out modified +12 −8
src/test/isolation/expected/insert-conflict-do-update.out modified +8 −4
src/test/isolation/expected/insert-conflict-specconflict.out modified +138 −62
src/test/isolation/expected/insert-conflict-toast.out modified +3 −1
src/test/isolation/expected/lock-committed-keyupdate.out modified +291 −117
src/test/isolation/expected/lock-committed-update.out modified +432 −168
src/test/isolation/expected/lock-update-delete_1.out modified +104 −40
src/test/isolation/expected/lock-update-delete.out modified +116 −44
src/test/isolation/expected/lock-update-traversal.out modified +24 −12
src/test/isolation/expected/multiple-cic.out modified +7 −3
src/test/isolation/expected/multiple-row-versions.out modified +12 −6
src/test/isolation/expected/multixact-no-deadlock.out modified +16 −8
src/test/isolation/expected/multixact-no-forget_1.out modified +68 −34
src/test/isolation/expected/multixact-no-forget.out modified +76 −38
src/test/isolation/expected/nowait-2.out modified +24 −12
src/test/isolation/expected/nowait-3.out modified +8 −4
src/test/isolation/expected/nowait-4_1.out modified +6 −2
src/test/isolation/expected/nowait-4.out modified +6 −2
src/test/isolation/expected/nowait-5.out modified +10 −4
src/test/isolation/expected/nowait.out modified +32 −16
src/test/isolation/expected/partial-index.out modified +536 −462
src/test/isolation/expected/predicate-lock-hot-tuple.out modified +10 −6
src/test/isolation/expected/prepared-transactions-cic.out modified +4 −2
src/test/isolation/expected/prepared-transactions.out modified +20043 −6681
src/test/isolation/expected/project-manager.out modified +160 −80
src/test/isolation/expected/read-write-unique-2.out modified +13 −5
src/test/isolation/expected/read-write-unique-3.out modified +4 −2
src/test/isolation/expected/read-write-unique-4.out modified +16 −8
src/test/isolation/expected/read-write-unique.out modified +13 −5
src/test/isolation/expected/receipt-report.out modified +1900 −1064
src/test/isolation/expected/referential-integrity.out modified +385 −175
src/test/isolation/expected/ri-trigger.out modified +40 −20
src/test/isolation/expected/skip-locked-2.out modified +36 −18
src/test/isolation/expected/skip-locked-3.out modified +12 −6
src/test/isolation/expected/skip-locked-4_1.out modified +6 −2
src/test/isolation/expected/skip-locked-4.out modified +10 −4
src/test/isolation/expected/skip-locked.out modified +320 −160
src/test/isolation/expected/temporal-range-integrity.out modified +160 −80
src/test/isolation/expected/timeouts.out modified +20 −12
src/test/isolation/expected/total-cash.out modified +136 −68
src/test/isolation/expected/tuplelock-conflict.out modified +320 −160
src/test/isolation/expected/tuplelock-update.out modified +17 −7
src/test/isolation/expected/tuplelock-upgrade-no-deadlock.out modified +115 −57
src/test/isolation/expected/two-ids.out modified +360 −180
src/test/isolation/expected/update-conflict-out.out modified +6 −2
src/test/isolation/expected/vacuum-reltuples.out modified +16 −8
src/test/isolation/isolationtester.c modified +6 −16
src/test/modules/brin/expected/summarization-and-inprogress-insertion.out modified +25 −13
src/test/modules/snapshot_too_old/expected/sto_using_cursor.out modified +44 −22
src/test/modules/snapshot_too_old/expected/sto_using_select.out modified +36 −18

Discussion