Remove some useless code

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: e439c6f0c3ddc6e4b71922ec326cb796c2885656
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2018-12-31T17:50:48Z
Releases: 12.0
Remove some useless code

In commit 8b08f7d4820f I added member relationId to IndexStmt struct.
I'm now not sure why; DefineIndex doesn't need it, since the relation
OID is passed as a separate argument anyway.  Remove it.

Also remove a redundant assignment to the relationId argument (it wasn't
redundant when added by commit e093dcdd285, but should have been removed
in commit 5f173040e3), and use relationId instead of stmt->relation when
locking the relation in the second phase of CREATE INDEX CONCURRENTLY,
which is not only confusing but it means we resolve the name twice for
no reason.

Files