Horton

Postpone calls of unsafe server-side functions in pg_dump.

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: e3fcbbd623b9ccc16cdbda374654d91a4727d173
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-12-06T17:49:49Z
Releases: 15.0 
Postpone calls of unsafe server-side functions in pg_dump.

Avoid calling pg_get_partkeydef(), pg_get_expr(relpartbound),
and regtypeout until we have lock on the relevant tables.
The existing coding is at serious risk of failure if there
are any concurrent DROP TABLE commands going on --- including
drops of other sessions' temp tables.

Arguably this is a bug fix that should be back-patched, but it's
moderately invasive and we've not had all that many complaints
about such failures.  Let's just put it in HEAD for now.

Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us
Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc

Files

PathChange+/−
src/bin/pg_dump/pg_dump.c modified +63 −30
src/bin/pg_dump/pg_dump.h modified +1 −3

Discussion