Horton

Skip second WriteToc() call for custom-format dumps without data.

Nathan Bossart <nathan@postgresql.org>

View on postgr.es
Commit: e3cc039a7d930ffe86e706944a2b3368bd3ef506
Author: Nathan Bossart <nathan@postgresql.org>
Date: 2025-04-04T19:51:08Z
Releases: 18.0 
Skip second WriteToc() call for custom-format dumps without data.

Presently, "pg_dump --format=custom" calls WriteToc() twice.  The
second call updates the data offset information, which allegedly
makes parallel pg_restore significantly faster.  However, if we're
not dumping any data, there are no data offsets to update, so we
can skip this step.

Reviewed-by: Jeff Davis <pgsql@j-davis.com>
Discussion: https://postgr.es/m/Z9c1rbzZegYQTOQE%40nathan

Files

PathChange+/−
src/bin/pg_dump/pg_backup_custom.c modified +4 −2

Discussion