Initial pgindent run with pg_bsd_indent version 2.0.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: e3860ffa4dd0dad0dd9eea4be9cc1412373a8c89
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-06-21T18:39:04Z
Releases: 10.0
Initial pgindent run with pg_bsd_indent version 2.0.

The new indent version includes numerous fixes thanks to Piotr Stefaniak.
The main changes visible in this commit are:

* Nicer formatting of function-pointer declarations.
* No longer unexpectedly removes spaces in expressions using casts,
  sizeof, or offsetof.
* No longer wants to add a space in "struct structname *varname", as
  well as some similar cases for const- or volatile-qualified pointers.
* Declarations using PG_USED_FOR_ASSERTS_ONLY are formatted more nicely.
* Fixes bug where comments following declarations were sometimes placed
  with no space separating them from the code.
* Fixes some odd decisions for comments following case labels.
* Fixes some cases where comments following code were indented to less
  than the expected column 33.

On the less good side, it now tends to put more whitespace around typedef
names that are not listed in typedefs.list.  This might encourage us to
put more effort into typedef name collection; it's not really a bug in
indent itself.

There are more changes coming after this round, having to do with comment
indentation and alignment of lines appearing within parentheses.  I wanted
to limit the size of the diffs to something that could be reviewed without
one's eyes completely glazing over, so it seemed better to split up the
changes as much as practical.

Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us

Files

PathChange+/−
contrib/bloom/blutils.c modified +1 −1
contrib/btree_gist/btree_utils_var.c modified +1 −1
contrib/dblink/dblink.c modified +2 −2
contrib/fuzzystrmatch/fuzzystrmatch.c modified +2 −2
contrib/intarray/_int_gin.c modified +1 −1
contrib/ltree/lquery_op.c modified +1 −1
contrib/oid2name/oid2name.c modified +7 −7
contrib/pgcrypto/imath.c modified +4 −4
contrib/pgcrypto/imath.h modified +3 −2
contrib/pgcrypto/internal.c modified +1 −1
contrib/pgcrypto/mbuf.h modified +2 −2
contrib/pgcrypto/pgp-decrypt.c modified +4 −4
contrib/pgcrypto/pgp-pgsql.c modified +5 −5
contrib/pgcrypto/px-crypt.c modified +2 −2
contrib/pgcrypto/px.h modified +3 −3
contrib/pgcrypto/rijndael.h modified +1 −2
contrib/pgcrypto/sha1.c modified +5 −5
contrib/pg_stat_statements/pg_stat_statements.c modified +1 −1
contrib/pgstattuple/pgstatapprox.c modified +1 −1
contrib/pgstattuple/pgstattuple.c modified +3 −3
contrib/pg_trgm/trgm_op.c modified +4 −4
contrib/pg_visibility/pg_visibility.c modified +1 −1
contrib/sepgsql/hooks.c modified +1 −1
contrib/sepgsql/label.c modified +2 −2
contrib/sepgsql/selinux.c modified +2 −2
contrib/sepgsql/sepgsql.h modified +1 −1
contrib/sepgsql/uavc.c modified +1 −1
contrib/spi/timetravel.c modified +1 −1
contrib/uuid-ossp/uuid-ossp.c modified +5 −5
contrib/vacuumlo/vacuumlo.c modified +2 −2
contrib/xml2/xpath.c modified +1 −1
src/backend/access/common/reloptions.c modified +14 −14
src/backend/access/gin/ginarrayproc.c modified +1 −1
src/backend/access/gin/gindatapage.c modified +1 −1
src/backend/access/hash/hash.c modified +1 −1
src/backend/access/hash/hashovfl.c modified +1 −1
src/backend/access/hash/hash_xlog.c modified +2 −2
src/backend/access/heap/rewriteheap.c modified +5 −5
src/backend/access/heap/tuptoaster.c modified +11 −11
src/backend/access/nbtree/nbtree.c modified +4 −4
src/backend/access/spgist/spgdoinsert.c modified +2 −2
src/backend/access/spgist/spgscan.c modified +2 −2
src/backend/access/transam/parallel.c modified +1 −1
src/backend/access/transam/slru.c modified +1 −1
src/backend/access/transam/twophase.c modified +2 −2
src/backend/access/transam/xlog.c modified +4 −4
src/backend/catalog/index.c modified +1 −1
src/backend/catalog/partition.c modified +3 −3
src/backend/commands/copy.c modified +1 −1
src/backend/commands/extension.c modified +2 −1
src/backend/commands/functioncmds.c modified +1 −1
src/backend/commands/publicationcmds.c modified +1 −1
src/backend/commands/tablecmds.c modified +26 −30
src/backend/commands/trigger.c modified +3 −3
src/backend/commands/vacuumlazy.c modified +4 −4
src/backend/executor/execCurrent.c modified +1 −1
src/backend/executor/functions.c modified +1 −1
src/backend/executor/nodeAgg.c modified +5 −5
src/backend/executor/nodeHashjoin.c modified +1 −1
src/backend/executor/nodeMaterial.c modified +1 −1
src/backend/executor/nodeMergejoin.c modified +2 −2
src/backend/executor/nodeProjectSet.c modified +1 −1
src/backend/executor/nodeSetOp.c modified +2 −2
src/backend/executor/nodeWindowAgg.c modified +1 −1
src/backend/lib/binaryheap.c modified +1 −1
src/backend/lib/ilist.c modified +1 −1
src/backend/libpq/auth.c modified +13 −12
src/backend/libpq/be-fsstubs.c modified +3 −3
src/backend/libpq/hba.c modified +9 −9
src/backend/libpq/ifaddr.c modified +26 −26
src/backend/libpq/pqcomm.c modified +3 −3
src/backend/lib/rbtree.c modified +3 −3
src/backend/nodes/nodeFuncs.c modified +2 −2
src/backend/optimizer/path/costsize.c modified +2 −2
src/backend/optimizer/path/joinrels.c modified +1 −1
src/backend/optimizer/prep/prepjointree.c modified +1 −1
src/backend/optimizer/util/predtest.c modified +1 −1
src/backend/parser/parse_expr.c modified +1 −1
src/backend/parser/parse_func.c modified +2 −2
src/backend/port/win32/crashdump.c modified +1 −1
src/backend/port/win32/socket.c modified +4 −4
src/backend/port/win32/timer.c modified +1 −1
src/backend/postmaster/autovacuum.c modified +3 −3
src/backend/postmaster/bgworker.c modified +1 −1
src/backend/postmaster/pgstat.c modified +7 −7
src/backend/postmaster/postmaster.c modified +12 −11
src/backend/postmaster/syslogger.c modified +1 −1
src/backend/regex/regc_color.c modified +42 −42
src/backend/regex/regc_cvec.c modified +5 −5
src/backend/regex/regc_lex.c modified +13 −13
src/backend/regex/regc_locale.c modified +8 −8
src/backend/regex/regc_nfa.c modified +121 −121
src/backend/regex/regcomp.c modified +67 −67
src/backend/regex/rege_dfa.c modified +25 −25
src/backend/regex/regerror.c modified +1 −1
src/backend/regex/regexec.c modified +32 −32
src/backend/regex/regexport.c modified +1 −1
src/backend/regex/regprefix.c modified +3 −3
src/backend/replication/basebackup.c modified +6 −6
src/backend/replication/logical/reorderbuffer.c modified +1 −2
src/backend/replication/walreceiver.c modified +1 −1
src/backend/replication/walsender.c modified +3 −2
src/backend/rewrite/rewriteHandler.c modified +1 −1
src/backend/snowball/dict_snowball.c modified +1 −1
src/backend/statistics/dependencies.c modified +4 −4
src/backend/statistics/extended_stats.c modified +1 −1
src/backend/statistics/mvdistinct.c modified +3 −3
src/backend/storage/buffer/bufmgr.c modified +2 −2
src/backend/storage/buffer/freelist.c modified +1 −1
src/backend/storage/ipc/dsm.c modified +1 −1
src/backend/storage/ipc/shmem.c modified +1 −1
src/backend/storage/ipc/shm_mq.c modified +3 −3
src/backend/storage/ipc/shm_toc.c modified +3 −3
src/backend/storage/lmgr/lwlock.c modified +8 −8
src/backend/storage/lmgr/predicate.c modified +1 −1
src/backend/storage/lmgr/proc.c modified +2 −2
src/backend/storage/lmgr/s_lock.c modified +4 −4
src/backend/storage/smgr/md.c modified +5 −5
src/backend/storage/smgr/smgr.c modified +6 −6
src/backend/tcop/fastpath.c modified +5 −5
src/backend/tcop/postgres.c modified +4 −4
src/backend/tcop/utility.c modified +1 −1
src/backend/tsearch/regis.c modified +3 −3
src/backend/tsearch/spell.c modified +1 −1
src/backend/tsearch/ts_typanalyze.c modified +4 −4
src/backend/tsearch/wparser_def.c modified +3 −3
src/backend/utils/adt/arrayfuncs.c modified +1 −1
src/backend/utils/adt/array_typanalyze.c modified +6 −6
src/backend/utils/adt/arrayutils.c modified +1 −1
src/backend/utils/adt/cash.c modified +3 −3
src/backend/utils/adt/date.c modified +9 −9
src/backend/utils/adt/datetime.c modified +33 −33
src/backend/utils/adt/dbsize.c modified +2 −2
src/backend/utils/adt/encode.c modified +1 −1
src/backend/utils/adt/formatting.c modified +12 −12
src/backend/utils/adt/geo_ops.c modified +13 −13
src/backend/utils/adt/int.c modified +1 −1
src/backend/utils/adt/jsonb.c modified +2 −2
src/backend/utils/adt/jsonfuncs.c modified +2 −1
src/backend/utils/adt/like_match.c modified +1 −1
src/backend/utils/adt/nabstime.c modified +5 −5
src/backend/utils/adt/pg_locale.c modified +4 −4
src/backend/utils/adt/rangetypes.c modified +1 −1
src/backend/utils/adt/ruleutils.c modified +10 −10
src/backend/utils/adt/selfuncs.c modified +3 −2
src/backend/utils/adt/timestamp.c modified +10 −10
src/backend/utils/adt/tsquery.c modified +2 −1
src/backend/utils/adt/tsrank.c modified +1 −1
src/backend/utils/adt/tsvector_op.c modified +4 −4
src/backend/utils/adt/tsvector_parser.c modified +1 −1
src/backend/utils/adt/varlena.c modified +1 −1
src/backend/utils/cache/catcache.c modified +1 −1
src/backend/utils/cache/inval.c modified +2 −2
src/backend/utils/cache/typcache.c modified +2 −2
src/backend/utils/error/elog.c modified +1 −1
src/backend/utils/fmgr/dfmgr.c modified +1 −1
src/backend/utils/fmgr/fmgr.c modified +4 −4
src/backend/utils/hash/dynahash.c modified +1 −1
src/backend/utils/mb/wchar.c modified +2 −2
src/backend/utils/misc/backend_random.c modified +2 −2
src/backend/utils/misc/guc.c modified +43 −43
src/backend/utils/mmgr/aset.c modified +2 −2
src/backend/utils/mmgr/slab.c modified +2 −2
src/backend/utils/resowner/resowner.c modified +1 −1
src/backend/utils/sort/tuplesort.c modified +4 −4
src/bin/initdb/findtimezone.c modified +6 −6
src/bin/initdb/initdb.c modified +7 −7
src/bin/pgbench/pgbench.c modified +9 −9
src/bin/pg_dump/parallel.h modified +3 −3
src/bin/pg_dump/pg_backup_custom.c modified +1 −1
src/bin/pg_dump/pg_backup.h modified +2 −2
src/bin/pg_dump/pg_backup_utils.c modified +1 −1
src/bin/pg_dump/pg_dump_sort.c modified +2 −2
src/bin/pgevent/pgevent.c modified +1 −1
src/bin/pg_upgrade/check.c modified +9 −9
src/bin/pg_upgrade/version.c modified +6 −6
src/bin/psql/conditional.h modified +1 −1
src/bin/psql/copy.c modified +1 −1
src/bin/psql/describe.c modified +2 −2
src/bin/psql/mainloop.c modified +1 −1
src/bin/psql/startup.c modified +2 −2
src/bin/psql/stringutils.c modified +2 −2
src/bin/psql/tab-complete.c modified +1 −1
src/common/exec.c modified +2 −2
src/common/ip.c modified +9 −9
src/common/unicode/norm_test.c modified +1 −1
src/fe_utils/mbprint.c modified +5 −5
src/fe_utils/print.c modified +14 −14
src/fe_utils/simple_list.c modified +1 −1
src/fe_utils/string_utils.c modified +2 −1
src/include/access/amapi.h modified +25 −25
src/include/access/gin_private.h modified +2 −2
src/include/access/ginxlog.h modified +1 −1
src/include/access/hash.h modified +2 −2
src/include/access/hash_xlog.h modified +1 −1
src/include/access/hio.h modified +1 −1
src/include/access/itup.h modified +2 −2
src/include/access/relscan.h modified +5 −5
src/include/access/slru.h modified +1 −1
src/include/access/tsmapi.h modified +10 −10
src/include/access/tupdesc.h modified +1 −1
src/include/access/tuptoaster.h modified +3 −3
src/include/access/twophase_rmgr.h modified +1 −1
src/include/access/xact.h modified +2 −2
src/include/access/xloginsert.h modified +5 −5
src/include/access/xlogreader.h modified +5 −5
src/include/access/xlogrecord.h modified +4 −3
src/include/catalog/index.h modified +5 −5
src/include/catalog/namespace.h modified +2 −2
src/include/catalog/objectaccess.h modified +4 −4
src/include/catalog/pg_db_role_setting.h modified +1 −1
src/include/catalog/pg_description.h modified +2 −2
src/include/catalog/pg_extension.h modified +1 −1
src/include/catalog/pg_init_privs.h modified +1 −1
src/include/catalog/pg_largeobject.h modified +2 −1
src/include/catalog/pg_pltemplate.h modified +2 −2
src/include/catalog/pg_proc.h modified +3 −3
src/include/catalog/pg_replication_origin.h modified +1 −1
src/include/catalog/pg_seclabel.h modified +3 −2
src/include/catalog/pg_shdescription.h modified +2 −2
src/include/catalog/pg_shseclabel.h modified +4 −3
src/include/catalog/pg_subscription.h modified +2 −2
src/include/catalog/pg_trigger.h modified +1 −1
src/include/c.h modified +1 −1
src/include/commands/explain.h modified +5 −5
src/include/commands/seclabel.h modified +1 −1
src/include/commands/vacuum.h modified +4 −4
src/include/common/int128.h modified +1 −1
src/include/common/ip.h modified +4 −4
src/include/common/unicode_norm_table.h modified +2 −1
src/include/executor/executor.h modified +3 −3
src/include/executor/hashjoin.h modified +3 −3
src/include/executor/tablefunc.h modified +3 −3
src/include/fe_utils/mbprint.h modified +1 −1
src/include/fe_utils/print.h modified +4 −4
src/include/fe_utils/psqlscan.h modified +1 −1
src/include/fmgr.h modified +5 −5
src/include/foreign/fdwapi.h modified +62 −62
src/include/getaddrinfo.h modified +3 −3
src/include/getopt_long.h modified +1 −1
src/include/lib/pairingheap.h modified +2 −2
src/include/libpq/ifaddr.h modified +7 −7
src/include/libpq/libpq-be.h modified +2 −2
src/include/lib/simplehash.h modified +10 −10
src/include/mb/pg_wchar.h modified +32 −30
src/include/nodes/execnodes.h modified +9 −9
src/include/nodes/extensible.h modified +18 −18
src/include/nodes/memnodes.h modified +1 −1
src/include/nodes/nodeFuncs.h modified +10 −10
src/include/nodes/nodes.h modified +1 −0
src/include/nodes/params.h modified +1 −1
src/include/nodes/parsenodes.h modified +2 −1
src/include/nodes/primnodes.h modified +7 −6
src/include/nodes/relation.h modified +7 −5
src/include/optimizer/cost.h modified +1 −1
src/include/optimizer/paths.h modified +14 −14
src/include/optimizer/plancat.h modified +3 −3
src/include/optimizer/planmain.h modified +1 −1
src/include/optimizer/planner.h modified +5 −5
src/include/parser/analyze.h modified +1 −1
src/include/parser/parse_node.h modified +2 −2
src/include/parser/parser.h modified +1 −1
src/include/pg_getopt.h modified +1 −1
src/include/pgstat.h modified +1 −1
src/include/pgtime.h modified +1 −1
src/include/port.h modified +7 −7
src/include/port/win32.h modified +5 −5
src/include/postgres.h modified +2 −2
src/include/postmaster/bgworker.h modified +1 −3
src/include/regex/regguts.h modified +1 −1
src/include/replication/logical.h modified +5 −5
src/include/replication/output_plugin.h modified +15 −15
src/include/replication/reorderbuffer.h modified +15 −15
src/include/replication/walreceiver.h modified +16 −16
src/include/rewrite/rowsecurity.h modified +1 −1
src/include/rusagestub.h modified +1 −1
src/include/statistics/statistics.h modified +1 −0
src/include/storage/itemptr.h modified +1 −0
src/include/storage/lock.h modified +1 −1
src/include/storage/lwlock.h modified +1 −1
src/include/storage/pg_shmem.h modified +1 −1
src/include/storage/predicate_internals.h modified +4 −4
src/include/tcop/dest.h modified +3 −3
src/include/tcop/utility.h modified +2 −2
src/include/tsearch/ts_utils.h modified +6 −6
src/include/utils/bytea.h modified +1 −1
src/include/utils/datetime.h modified +13 −13
src/include/utils/elog.h modified +1 −1
src/include/utils/expandeddatum.h modified +1 −1
src/include/utils/guc.h modified +1 −1
src/include/utils/guc_tables.h modified +2 −2
src/include/utils/hsearch.h modified +1 −1
src/include/utils/nabstime.h modified +1 −1
src/include/utils/portal.h modified +1 −1
src/include/utils/rangetypes.h modified +2 −2
src/include/utils/rel.h modified +1 −1
src/include/utils/resowner.h modified +3 −3
src/include/utils/selfuncs.h modified +6 −6
src/include/utils/snapshot.h modified +1 −1
src/include/utils/timestamp.h modified +5 −5
src/include/utils/xml.h modified +2 −2
src/interfaces/ecpg/compatlib/informix.c modified +3 −3
src/interfaces/ecpg/ecpglib/connect.c modified +1 −1
src/interfaces/ecpg/ecpglib/descriptor.c modified +5 −5
src/interfaces/ecpg/ecpglib/execute.c modified +14 −14
src/interfaces/ecpg/ecpglib/extern.h modified +6 −6
src/interfaces/ecpg/ecpglib/memory.c modified +1 −1
src/interfaces/ecpg/ecpglib/misc.c modified +2 −2
src/interfaces/ecpg/ecpglib/prepare.c modified +7 −7
src/interfaces/ecpg/ecpglib/sqlda.c modified +2 −2
src/interfaces/ecpg/include/ecpg_informix.h modified +1 −1
src/interfaces/ecpg/include/ecpglib.h modified +1 −1
src/interfaces/ecpg/include/ecpgtype.h modified +1 −1
src/interfaces/ecpg/include/pgtypes_date.h modified +2 −2
src/interfaces/ecpg/include/pgtypes_interval.h modified +4 −4
src/interfaces/ecpg/include/pgtypes_numeric.h modified +1 −1
src/interfaces/ecpg/include/pgtypes_timestamp.h modified +1 −1
src/interfaces/ecpg/include/sqlca.h modified +1 −1
src/interfaces/ecpg/pgtypeslib/dt_common.c modified +27 −27
src/interfaces/ecpg/pgtypeslib/dt.h modified +3 −3
src/interfaces/ecpg/pgtypeslib/interval.c modified +11 −11
src/interfaces/ecpg/pgtypeslib/timestamp.c modified +9 −9
src/interfaces/ecpg/preproc/extern.h modified +1 −1
src/interfaces/ecpg/preproc/output.c modified +2 −2
src/interfaces/ecpg/preproc/type.c modified +11 −11
src/interfaces/ecpg/preproc/variable.c modified +7 −7
src/interfaces/ecpg/test/expected/compat_informix-test_informix2.c modified +1 −1
src/interfaces/ecpg/test/expected/preproc-init.c modified +1 −1
src/interfaces/ecpg/test/expected/preproc-outofscope.c modified +1 −1
src/interfaces/ecpg/test/expected/sql-array.c modified +1 −1
src/interfaces/ecpg/test/expected/sql-code100.c modified +1 −1
src/interfaces/ecpg/test/expected/sql-copystdout.c modified +1 −1
src/interfaces/ecpg/test/expected/sql-define.c modified +1 −1
src/interfaces/ecpg/test/expected/sql-dynalloc2.c modified +1 −1
src/interfaces/ecpg/test/expected/sql-dynalloc.c modified +1 −1
src/interfaces/ecpg/test/expected/sql-dyntest.c modified +1 −1
src/interfaces/ecpg/test/expected/sql-indicators.c modified +1 −1
src/interfaces/ecpg/test/expected/sql-sqlda.c modified +1 −1
src/interfaces/ecpg/test/expected/thread-alloc.c modified +1 −1
src/interfaces/ecpg/test/expected/thread-descriptor.c modified +1 −1
src/interfaces/ecpg/test/expected/thread-prep.c modified +1 −1
src/interfaces/ecpg/test/regression.h modified +4 −4
src/interfaces/libpq/fe-connect.c modified +11 −11
src/interfaces/libpq/fe-exec.c modified +7 −7
src/interfaces/libpq/fe-print.c modified +1 −1
src/interfaces/libpq/fe-secure-openssl.c modified +1 −1
src/interfaces/libpq/libpq-events.h modified +1 −1
src/interfaces/libpq/libpq-fe.h modified +12 −12
src/interfaces/libpq/win32.c modified +2 −2
src/pl/plperl/plperl.c modified +1 −1
src/pl/plpgsql/src/pl_comp.c modified +2 −2
src/pl/plpgsql/src/pl_exec.c modified +1 −1
src/pl/plpgsql/src/pl_funcs.c modified +1 −1
src/pl/plpgsql/src/plpgsql.h modified +1 −1
src/pl/plpython/plpy_exec.c modified +1 −1
src/pl/tcl/pltcl.c modified +1 −1
src/port/crypt.c modified +3 −0
src/port/dirmod.c modified +1 −1
src/port/getaddrinfo.c modified +13 −13
src/port/getopt.c modified +1 −1
src/port/getopt_long.c modified +1 −1
src/port/getrusage.c modified +1 −1
src/port/gettimeofday.c modified +2 −2
src/port/inet_aton.c modified +5 −5
src/port/mkdtemp.c modified +1 −1
src/port/thread.c modified +4 −4
src/port/win32error.c modified +1 −1
src/port/win32setlocale.c modified +1 −1
src/test/modules/worker_spi/worker_spi.c modified +1 −1
src/test/regress/pg_regress.h modified +3 −3
src/test/regress/regress.c modified +1 −1
src/timezone/localtime.c modified +14 −14
src/timezone/pgtz.h modified +3 −3
src/timezone/strftime.c modified +2 −2
src/timezone/zic.c modified +30 −30
src/tools/ifaddrs/test_ifaddrs.c modified +2 −2
src/tools/testint128.c modified +2 −2
src/tutorial/complex.c modified +1 −1
src/tutorial/funcs.c modified +1 −1

Discussion