Remove _configthreadlocale() calls in ecpg test suite.
Tom Lane <tgl@sss.pgh.pa.us>
Remove _configthreadlocale() calls in ecpg test suite. This essentially reverts commits a772624b1 and 04fbe0e45, which added "_configthreadlocale(_ENABLE_PER_THREAD_LOCALE)" calls to the thread-related ecpg test programs. That was nothing but a hack, because we shouldn't expect that ecpg-using applications have done that for us; and now that we've inserted such calls into ecpglib, the tests should still pass without it. (If they don't, it would be good to know that.) HEAD only; there seems no big need to change this in the back branches. Discussion: https://postgr.es/m/22937.1548307384@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/interfaces/ecpg/test/expected/thread-alloc.c | modified | +9 −15 |
| src/interfaces/ecpg/test/expected/thread-descriptor.c | modified | +4 −10 |
| src/interfaces/ecpg/test/expected/thread-prep.c | modified | +23 −29 |
| src/interfaces/ecpg/test/expected/thread-thread.c | modified | +11 −17 |
| src/interfaces/ecpg/test/expected/thread-thread_implicit.c | modified | +11 −17 |
| src/interfaces/ecpg/test/thread/alloc.pgc | modified | +0 −6 |
| src/interfaces/ecpg/test/thread/descriptor.pgc | modified | +0 −6 |
| src/interfaces/ecpg/test/thread/prep.pgc | modified | +0 −6 |
| src/interfaces/ecpg/test/thread/thread_implicit.pgc | modified | +0 −6 |
| src/interfaces/ecpg/test/thread/thread.pgc | modified | +0 −6 |
Discussion
- Thread-unsafe coding in ecpg 37 messages · 2019-01-18 → 2019-01-29