Attached is my attempt to clean up the horrors of the ExecSQL() method in
Bruce Momjian <bruce@momjian.us>
Attached is my attempt to clean up the horrors of the ExecSQL() method in the JDBC driver. I've done this by extracting it into a new method object called QueryExecutor (should go into org/postgresql/core/) and then taking it apart into different methods in that class. A short summary: * Extracted ExecSQL() from Connection into a method object called QueryExecutor. * Moved ReceiveFields() from Connection to QueryExecutor. * Extracted parts of the original ExecSQL() method body into smaller methods on QueryExecutor. * Bug fix: The instance variable "pid" in Connection was used in two places with different meaning. Both were probably in dead code, but it's fixed anyway. Anders Bengtsson
Files
| Path | Change | +/− |
|---|---|---|
| src/interfaces/jdbc/org/postgresql/Connection.java | modified | +5 −162 |
| src/interfaces/jdbc/org/postgresql/jdbc1/Connection.java | modified | +2 −2 |
| src/interfaces/jdbc/org/postgresql/jdbc2/Connection.java | modified | +2 −2 |