Fix gist_bool_ops to use gbtreekey2

Tomas Vondra <tomas.vondra@postgresql.org>

Commit: e2fbb883720aa222f61eb9f3affad1c63bac7cbb
Author: Tomas Vondra <tomas.vondra@postgresql.org>
Date: 2021-11-08T00:14:55Z
Releases: 15.0
Fix gist_bool_ops to use gbtreekey2

Commit 57e3c5160b added a new GiST bool opclass, but it used gbtreekey4
to store the data, which left two bytes undefined, as reported by skink,
our valgrind animal. There was a bit more confusion, because the opclass
also used gbtreekey8 in the definition.

Fix by defining a new gbtreekey2 struct, and using it in all the places.

Discussion: https://postgr.es/m/CAE2gYzyDKJBZngssR84VGZEN=Ux=V9FV23QfPgo+7-yYnKKg4g@mail.gmail.com

Files

Discussion