Horton

Replace flaky CIC/RI isolation tests with a TAP test

Álvaro Herrera <alvherre@kurilemu.de>

View on postgr.es
Commit: e1c971945d62d3150ecfe353ce7bb4263916b489
Author: Álvaro Herrera <alvherre@kurilemu.de>
Date: 2026-01-07T22:44:57Z
Releases: 19 (unreleased) 
Replace flaky CIC/RI isolation tests with a TAP test

The isolation tests for INSERT ON CONFLICT behavior during CREATE INDEX
CONCURRENTLY and REINDEX CONCURRENTLY (added by bc32a12e0db2,
2bc7e886fc1b, and 90eae926abbb) were disabled in 77038d6d0b49 due to
persistent CI flakiness, after several attempts at stabilization.

This commit removes them and introduces a TAP test in test_misc module
(010_index_concurrently_upsert.pl) that covers the same scenarios.  This
new test should hopefully be more stable while providing assurance that
the fixes in all those commits (plus 81f72115cf18) continue to work.

Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Reported-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/ccssrhafzbp3a3beju3ptyc56a7gbfimj4vwkbokoldofckrc7@bso37rxskjtf
Discussion: https://postgr.es/m/CANtu0ogv+6wqRzPK241jik4U95s1pW3MCZ3rX5ZqbFdUysz7Qw@mail.gmail.com
Discussion: https://postgr.es/m/202512112014.icpomgc37zx4@alvherre.pgsql

Files

PathChange+/−
src/test/modules/injection_points/expected/index-concurrently-upsert_1.out deleted +0 −124
src/test/modules/injection_points/expected/index-concurrently-upsert.out deleted +0 −123
src/test/modules/injection_points/expected/index-concurrently-upsert-predicate_1.out deleted +0 −124
src/test/modules/injection_points/expected/index-concurrently-upsert-predicate.out deleted +0 −123
src/test/modules/injection_points/expected/reindex-concurrently-upsert-on-constraint.out deleted +0 −238
src/test/modules/injection_points/expected/reindex-concurrently-upsert.out deleted +0 −238
src/test/modules/injection_points/expected/reindex-concurrently-upsert-partitioned.out deleted +0 −238
src/test/modules/injection_points/Makefile modified +0 −8
src/test/modules/injection_points/meson.build modified +0 −6
src/test/modules/injection_points/specs/index-concurrently-upsert-predicate.spec deleted +0 −124
src/test/modules/injection_points/specs/index-concurrently-upsert.spec deleted +0 −123
src/test/modules/injection_points/specs/reindex-concurrently-upsert-on-constraint.spec deleted +0 −110
src/test/modules/injection_points/specs/reindex-concurrently-upsert-partitioned.spec deleted +0 −113
src/test/modules/injection_points/specs/reindex-concurrently-upsert.spec deleted +0 −111
src/test/modules/test_misc/Makefile modified +3 −0
src/test/modules/test_misc/meson.build modified +3 −0
src/test/modules/test_misc/t/010_index_concurrently_upsert.pl added +902 −0

Discussion