Fix MarkBufferDirtyHint() to not call GetBufferDescriptor() for local buffers

Michael Paquier <michael@paquier.xyz>

Commit: e18b0cb7344cb4bd28468f6c0aeeb9b9241d30aa
Author: Michael Paquier <michael@paquier.xyz>
Date: 2026-06-10T04:49:26Z
Fix MarkBufferDirtyHint() to not call GetBufferDescriptor() for local buffers

GetBufferDescriptor() was called before checking if the buffer is local.
Such buffers have a negative ID, meaning that we could call
GetBufferDescriptor() with a wrapped-around uint32 value causing a
potential out-of-bound access to the BufferDescriptors array.

This is harmless in the existing code for the current uses of
MarkBufferDirtyHint(), but the author has found a way to make that
buggy while working on a different patch set, and the order of the
operations is wrong.

Oversight in 82467f627bd4.  No backpatch is required, as this is new to
v19.

Author: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Discussion: https://postgr.es/m/CAExHW5uzRMYVZsXXS3HXXT0fG_sNrpUhUqwP4NorhaCqH9JDhA@mail.gmail.com

Files

PathChange+/−
src/backend/storage/buffer/bufmgr.c modified +2 −2

Discussion