Select CFLAGS_SL at configure time, not in platform-specific Makefiles.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: e167b1ae37ad0dad985b843c6ba654c3619ced26
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-10-21T16:32:36Z
Releases: 10.11
Select CFLAGS_SL at configure time, not in platform-specific Makefiles.

Move the platform-dependent logic that sets CFLAGS_SL from
src/makefiles/Makefile.foo to src/template/foo, so that the value
is determined at configure time and thus is available while running
configure's tests.

On a couple of platforms this might save a few microseconds of build
time by eliminating a test that make otherwise has to do over and over.
Otherwise it's pretty much a wash for build purposes; in particular,
this makes no difference to anyone who might be overriding CFLAGS_SL
via a make option.

This patch in itself does nothing with the value and thus should not
change any behavior, though you'll probably have to re-run configure
to get a correctly updated Makefile.global.  We'll use the new
configure variable in a follow-on patch.

Per gripe from Kyotaro Horiguchi.  Back-patch to all supported branches,
because the follow-on patch is a portability bug fix.

Discussion: https://postgr.es/m/20191010.144533.263180400.horikyota.ntt@gmail.com

Files

PathChange+/−
configure modified +4 −1
configure.in modified +4 −1
src/Makefile.global.in modified +1 −0
src/makefiles/Makefile.cygwin modified +0 −1
src/makefiles/Makefile.freebsd modified +0 −2
src/makefiles/Makefile.hpux modified +0 −5
src/makefiles/Makefile.linux modified +0 −2
src/makefiles/Makefile.netbsd modified +0 −2
src/makefiles/Makefile.openbsd modified +0 −2
src/makefiles/Makefile.solaris modified +1 −5
src/makefiles/Makefile.win32 modified +0 −1
src/template/aix modified +5 −0
src/template/cygwin modified +3 −0
src/template/darwin modified +3 −0
src/template/freebsd modified +3 −0
src/template/hpux modified +7 −0
src/template/linux modified +3 −0
src/template/netbsd modified +3 −0
src/template/openbsd modified +4 −0
src/template/solaris modified +9 −0
src/template/win32 modified +3 −0

Discussion