hstore: Tighten key/value parsing check for whitespaces

Michael Paquier <michael@paquier.xyz>

Commit: e0e6829459b0e0566dc4493675522afb69d39f36
Author: Michael Paquier <michael@paquier.xyz>
Date: 2023-06-12T00:14:14Z
Releases: 14.9
hstore: Tighten key/value parsing check for whitespaces

isspace() can be locale-sensitive depending on the platform, causing
hstore to consider as whitespaces characters it should not see as such.
For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be
discarded from the input given.

This problem is similar to 9ae2661, though it was missed that hstore
can also manipulate non-ASCII inputs, so replace the existing isspace()
calls with scanner_isspace().

This problem exists for a long time, so backpatch all the way down.

Author: Evan Jones
Discussion: https://postgr.es/m/CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com
Backpatch-through: 11

Files

Discussion