Make executor's SELECT INTO code save and restore original tuple receiver.
Tom Lane <tgl@sss.pgh.pa.us>
Make executor's SELECT INTO code save and restore original tuple receiver. As previously coded, the QueryDesc's dest pointer was left dangling (pointing at an already-freed receiver object) after ExecutorEnd. It's a bit astonishing that it took us this long to notice, and I'm not sure that the known problem case with SQL functions is the only one. Fix it by saving and restoring the original receiver pointer, which seems the most bulletproof way of ensuring any related bugs are also covered. Per bug #6379 from Paul Ramsey. Back-patch to 8.4 where the current handling of SELECT INTO was introduced.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/execMain.c | modified | +15 −5 |
| src/test/regress/expected/select_into.out | modified | +25 −0 |
| src/test/regress/sql/select_into.sql | modified | +15 −0 |