Remove XLogFileInit() ability to skip ControlFileLock.
Noah Misch <noah@leadboat.com>
Author:
Noah Misch <noah@leadboat.com>
Committer:
Michael Paquier <michael@paquier.xyz>
Date: 2025-04-06T05:22:46Z
Releases:
13.21
Remove XLogFileInit() ability to skip ControlFileLock. Cold paths, initdb and end-of-recovery, used it. Don't optimize them. This commit has been applied as of c53c6b98d38a in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/transam/xlog.c | modified | +14 −32 |
| src/backend/replication/walreceiver.c | modified | +1 −1 |
| src/include/access/xlog.h | modified | +1 −1 |
Discussion
- Race between KeepFileRestoredFromArchive() and restartpoint 15 messages · 2021-02-02 → 2022-08-04
- avoid multiple hard links to same WAL file after a crash 59 messages · 2022-04-07 → 2025-04-26