Allow pg_dump to dump non-extension members of an extension-owned schema.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: df5d9bb8d5074138e6fea63ac8acd9b95a0eb859
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-09-08T17:12:01Z
Releases: 10.0
Allow pg_dump to dump non-extension members of an extension-owned schema.

Previously, if a schema was created by an extension, a normal pg_dump run
(not --binary-upgrade) would summarily skip every object in that schema.
In a case where an extension creates a schema and then users create other
objects within that schema, this does the wrong thing: we want pg_dump
to skip the schema but still create the non-extension-owned objects.

There's no easy way to fix this pre-9.6, because in earlier versions the
"dump" status for a schema is just a bool and there's no way to distinguish
"dump me" from "dump my members".  However, as of 9.6 we do have enough
state to represent that, so this is a simple correction of the logic in
selectDumpableNamespace.

In passing, make some cosmetic fixes in nearby code.

Martín Marqués, reviewed by Michael Paquier

Discussion: <99581032-71de-6466-c325-069861f1947d@2ndquadrant.com>

Files