Horton

Re-add default_with_oids GUC to avoid breaking old dump files.

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: de66987adb8a3414724b99540d324407bfad697a
Author: Andres Freund <andres@anarazel.de>
Date: 2019-01-14T23:30:24Z
Releases: 12.0 
Re-add default_with_oids GUC to avoid breaking old dump files.

After 578b229718 / the removal of WITH OIDS support, older dump files
containing
    SET default_with_oids = false;
either report unnecessary errors (as the subsequent tables have no
oids) or even fail to restore entirely (when using transaction mode).
To avoid that, re-add the GUC, but don't allow setting it to true.

Per complaint from Tom Lane.

Author: Amit Khandekar, editorialized by me
Discussion: https://postgr.es/m/CAJ3gD9dZyxrtL0rJfoNoOj6v7fJSDaXBngi9wy5XU8m-ioXhAA@mail.gmail.com

Files

PathChange+/−
src/backend/utils/misc/guc.c modified +37 −0
src/test/regress/expected/guc.out modified +4 −0
src/test/regress/sql/guc.sql modified +4 −0

Discussion