Fix assertion failure in apply worker.

Amit Kapila <akapila@postgresql.org>

Commit: de63f8dadee4afa152ce177fd3c562d47373a728
Author: Amit Kapila <akapila@postgresql.org>
Date: 2023-05-03T04:47:49Z
Releases: 16.0
Fix assertion failure in apply worker.

During exit, the logical replication apply worker tries to release session
level locks, if any. However, if the apply worker exits due to an error
before its connection is initialized, trying to release locks can lead to
assertion failure. The locks will be acquired once the worker is
initialized, so we don't need to release them till the worker
initialization is complete.

Reported-by: Alexander Lakhin
Author: Hou Zhijie based on inputs from Sawada Masahiko and Amit Kapila
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/2185d65f-5aae-3efa-c48f-fb42b173ef5c@gmail.com

Files

Discussion