Use heap_modify_tuple not SPI_modifytuple in pl/python triggers.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: de4026c673f195cfdb7aa7cc87cc60e36963f094
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-11-08T17:00:24Z
Releases: 10.0
Use heap_modify_tuple not SPI_modifytuple in pl/python triggers.

The code here would need some change anyway given planned change in
SPI_modifytuple semantics, since this executes after we've exited the
SPI environment.  But really it's better to just use heap_modify_tuple.

While at it, normalize use of SPI_fnumber: make error messages distinguish
no-such-column from can't-set-system-column, and remove test for deleted
column which is going to migrate into SPI_fnumber.  The lack of a check
for system column names is actually a pre-existing bug here, and might
even qualify as a security bug except that we don't have any trusted
version of plpython.

Files

PathChange+/−
src/pl/plpython/plpy_exec.c modified +41 −45