libpq_pipeline: Must strdup(optarg) to avoid crash
Alvaro Herrera <alvherre@alvh.no-ip.org>
libpq_pipeline: Must strdup(optarg) to avoid crash I forgot to strdup() when processing argv[]. Apparently many platforms hide this mistake from users, but in those that don't you may get a program crash. Repair. Per buildfarm member drongo, which is the only one in all the buildfarm manifesting a problem here. While at it, move "numrows" processing out of the line of special cases, and make it getopt's -r instead. (A similar thing could be done to 'conninfo', but current use of the program doesn't warrant spending time on that -- nowhere else we use conninfo in so simplistic a manner.) Discussion: https://postgr.es/m/20210401124850.GA19247@alvherre.pgsql
Files
| Path | Change | +/− |
|---|---|---|
| src/test/modules/libpq_pipeline/libpq_pipeline.c | modified | +16 −16 |
| src/test/modules/libpq_pipeline/t/001_libpq_pipeline.pl | modified | +2 −3 |
Discussion
- libpq debug log 232 messages · 2018-08-24 → 2021-06-11