Horton

Avoid repeating loads of frozen ID values.

Noah Misch <noah@leadboat.com>

View on postgr.es
Commit: dd0183469bb779247c96e86c2272dca7ff4ec9e7
Author: Noah Misch <noah@leadboat.com>
Date: 2024-04-29T17:25:33Z
Releases: 17.0 
Avoid repeating loads of frozen ID values.

Repeating loads of inplace-updated fields tends to cause bugs like the
one from the previous commit.  While there's no bug to fix in these code
sites, adopt the load-once style.  This improves the chance of future
copy/paste finding the safe style.

Discussion: https://postgr.es/m/20240423003956.e7.nmisch@google.com

Files

PathChange+/−
src/backend/access/heap/heapam.c modified +10 −6
src/backend/commands/cluster.c modified +14 −8
src/backend/commands/vacuum.c modified +2 −2
src/backend/postmaster/autovacuum.c modified +8 −5

Discussion