Rewrite LIKE's %-followed-by-_ optimization so it really works (this time

Tom Lane <tgl@sss.pgh.pa.us>

Commit: dbde97cdde4afbd0a175880446e301f1bfb8994c
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2010-05-28T17:35:23Z
Releases: 9.0.0
Rewrite LIKE's %-followed-by-_ optimization so it really works (this time
for sure ;-)).  It now also optimizes more cases, such as %_%_.  Improve
comments too.  Per bug #5478.

In passing, also rename the TCHAR macro to GETCHAR, because pgindent is
messing with the formatting of the former (apparently it now thinks TCHAR
is a typedef name).

Back-patch to 8.3, where the bug was introduced.

Files