Work around a subtle portability problem in use of printf %s format.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: db01ccc05215f452903a602d1c7788575a7d61bf
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2010-05-08T16:40:14Z
Releases: 8.3.11
Work around a subtle portability problem in use of printf %s format.
Depending on which spec you read, field widths and precisions in %s may be
counted either in bytes or characters.  Our code was assuming bytes, which
is wrong at least for glibc's implementation, and in any case libc might
have a different idea of the prevailing encoding than we do.  Hence, for
portable results we must avoid using anything more complex than just "%s"
unless the string to be printed is known to be all-ASCII.

This patch fixes the cases I could find, including the psql formatting
failure reported by Hernan Gonzalez.  In HEAD only, I also added comments
to some places where it appears safe to continue using "%.*s".

Files

PathChange+/−
src/backend/parser/scansup.c modified +13 −3
src/backend/utils/error/elog.c modified +3 −3
src/interfaces/libpq/fe-misc.c modified +25 −4