Reduce memory usage of tsvector type analyze function.

Heikki Linnakangas <heikki.linnakangas@iki.fi>

Commit: da11977de9c685ef808d3a293727f9ce26753ec4
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2017-07-12T19:06:13Z
Releases: 10.0
Reduce memory usage of tsvector type analyze function.

compute_tsvector_stats() detoasted and kept in memory every tsvector value
in the sample, but that can be a lot of memory. The original bug report
described a case using over 10 gigabytes, with statistics target of 10000
(the maximum).

To fix, allocate a separate copy of just the lexemes that we keep around,
and free the detoasted tsvector values as we go. This adds some palloc/pfree
overhead, when you have a lot of distinct lexemes in the sample, but it's
better than running out of memory.

Fixes bug #14654 reported by James C. Reviewed by Tom Lane. Backport to
all supported versions.

Discussion: https://www.postgresql.org/message-id/20170514200602.1451.46797@wrigleys.postgresql.org

Files

PathChange+/−
src/backend/tsearch/ts_typanalyze.c modified +17 −4

Discussion