pg_upgrade: generate check error for left-over new tablespace

Bruce Momjian <bruce@momjian.us>

Commit: d9ae2297bf0f668467780bd80815a4a2d30e822c
Author: Bruce Momjian <bruce@momjian.us>
Date: 2020-10-15T23:33:36Z
Releases: 9.5.24
pg_upgrade:  generate check error for left-over new tablespace

Previously, if pg_upgrade failed, and the user recreated the cluster but
did not remove the new cluster tablespace directory, a later pg_upgrade
would fail since the new tablespace directory would already exists.
This adds error reporting for this during check.

Reported-by: Justin Pryzby

Discussion: https://postgr.es/m/20200925005531.GJ23631@telsasoft.com

Backpatch-through: 9.5

Files

PathChange+/−
src/bin/pg_upgrade/check.c modified +40 −0