Make sampler_random_fract() actually obey its API contract.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: d7c19d68550eb6018e8581a73a351905f4cc435c
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2015-07-01T22:07:48Z
Releases: 9.6.0
Make sampler_random_fract() actually obey its API contract.

This function is documented to return a value in the range (0,1),
which is what its predecessor anl_random_fract() did.  However, the
new version depends on pg_erand48() which returns a value in [0,1).
The possibility of returning zero creates hazards of division by zero
or trying to compute log(0) at some call sites, and it might well
break third-party modules using anl_random_fract() too.  So let's
change it to never return zero.  Spotted by Coverity.

Michael Paquier, cosmetically adjusted by me

Files

PathChange+/−
src/backend/utils/misc/sampling.c modified +8 −1