Add missing bad-PGconn guards in libpq entry points.
Tom Lane <tgl@sss.pgh.pa.us>
Add missing bad-PGconn guards in libpq entry points. There's a convention that externally-visible libpq functions should check for a NULL PGconn pointer, and fail gracefully instead of crashing. PQflush() and PQisnonblocking() didn't get that memo though. Also add a similar check to PQdefaultSSLKeyPassHook_OpenSSL; while it's not clear that ordinary usage could reach that with a null conn pointer, it's cheap enough to check, so let's be consistent. Daniele Varrazzo and Tom Lane Discussion: https://postgr.es/m/CA+mi_8Zm_mVVyW1iNFgyMd9Oh0Nv8-F+7Y3-BqwMgTMHuo_h2Q@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/interfaces/libpq/fe-exec.c | modified | +4 −0 |
| src/interfaces/libpq/fe-secure-openssl.c | modified | +1 −1 |
Discussion
- [PATCH] Fix segfault calling PQflush on invalid connection 6 messages · 2022-08-15 → 2022-08-16