Fix corner-case coredump in _SPI_error_callback().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: d5f767c136d2531ad58053498c7236706779f692
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-12-11T21:33:54Z
Releases: 9.3.21
Fix corner-case coredump in _SPI_error_callback().

I noticed that _SPI_execute_plan initially sets spierrcontext.arg = NULL,
and only fills it in some time later.  If an error were to happen in
between, _SPI_error_callback would try to dereference the null pointer.
This is unlikely --- there's not much between those points except
push-snapshot calls --- but it's clearly not impossible.  Tweak the
callback to do nothing if the pointer isn't set yet.

It's been like this for awhile, so back-patch to all supported branches.

Files

PathChange+/−
src/backend/executor/spi.c modified +3 −0