Revert "Add log_statement_sample_rate parameter"
Tomas Vondra <tomas.vondra@postgresql.org>
Revert "Add log_statement_sample_rate parameter" This reverts commit 88bdbd3f746049834ae3cc972e6e650586ec3c9d. As committed, statement sampling used the existing duration threshold (log_min_duration_statement) when decide which statements to sample. The issue is that even the longest statements are subject to sampling, and so may not end up logged. An improvement was proposed, introducing a second duration threshold, but it would not be backwards compatible. So we've decided to revert this feature - the separate threshold should be part of the feature itself. Discussion: https://postgr.es/m/CAFj8pRDS8tQ3Wviw9%3DAvODyUciPSrGeMhJi_WPE%2BEB8%2B4gLL-Q%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/config.sgml | modified | +6 −28 |
| src/backend/tcop/postgres.c | modified | +2 −14 |
| src/backend/utils/misc/guc.c | modified | +1 −14 |
| src/backend/utils/misc/postgresql.conf.sample | modified | +4 −8 |
| src/include/utils/guc.h | modified | +0 −1 |
Documentation touched
Discussion
- idea: log_statement_sample_rate - bottom limit for sampling 28 messages · 2019-06-06 → 2019-11-06