Horton

Fix new assertion for MERGE view_name ... DO NOTHING.

Noah Misch <noah@leadboat.com>

View on postgr.es
Commit: d5e6891502ca9e359aa5f5a381d904fe9d606338
Author: Noah Misch <noah@leadboat.com>
Date: 2024-07-13T15:09:33Z
Releases: 18.0 
Fix new assertion for MERGE view_name ... DO NOTHING.

Such queries don't expand automatically updatable views, and ModifyTable
uses the wholerow attribute unconditionally.  The user-visible behavior
is fine, so change to more-specific assertions.  Commit
d5f788b41dc2cbdde6e7694c70dda54d829a5ed5 added the wrong assertion.
Back-patch to v17, where commit 5f2e179bd31e5f5803005101eb12a8d7bf8db8f3
introduced MERGE view_name.

Reported by Alexander Lakhin.

Discussion: https://postgr.es/m/e4b40a88-c134-6926-3196-bc4501cb87a2@gmail.com

Files

PathChange+/−
src/backend/executor/nodeModifyTable.c modified +23 −17
src/test/regress/expected/updatable_views.out modified +5 −0
src/test/regress/sql/updatable_views.sql modified +5 −0

Discussion