Add missing check_collation_set call to bpcharne().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: d57d61533a2b5b27b60cc9024c54688390871bf6
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-11-13T20:53:53Z
Releases: 13.0
Add missing check_collation_set call to bpcharne().

We should throw an error for indeterminate collation, but bpcharne()
was missing that logic, resulting in a much less user-friendly error
(either an assertion failure or "cache lookup failed for collation 0").

Per report from Manuel Rigger.  Back-patch to v12 where the mistake
came in, evidently in commit 5e1963fb7.  (Before non-deterministic
collations, this function wasn't collation sensitive.)

Discussion: https://postgr.es/m/CA+u7OA4HOjtymxAbuGNh4-X_2R0Lw5n01tzvP8E5-i-2gQXYWA@mail.gmail.com

Files

PathChange+/−
src/backend/utils/adt/varchar.c modified +2 −0

Discussion