Revert "Fix "pg_ctl start -w" to test child process status directly."

Tom Lane <tgl@sss.pgh.pa.us>

Commit: d56c02f1ac9247295ec1e5143361020a91f708c8
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-06-19T17:45:03Z
Releases: 9.1.23
Revert "Fix "pg_ctl start -w" to test child process status directly."

This reverts commit c869a7d5b44e7164fadfb638786def05d510312a.
As pointed out by Maksym Sobolyev in bug #14199, that approach doesn't
work if the postmaster forks itself an extra time due to silent_mode
being enabled.  We removed silent_mode in 9.2, so the pg_ctl change is
fine in 9.2 and later, but it fails when that option is enabled in 9.1.
Seeing that 9.1 is close to end-of-life, let's adopt the most conservative
fix we can, which is to revert the pg_ctl change in the 9.1 branch.

Discussion: <20160618042812.5798.85609@wrigleys.postgresql.org>

Files

PathChange+/−
src/bin/pg_ctl/pg_ctl.c modified +78 −107