Fix more strcmp() calls using boolean-like comparisons for result checks
Michael Paquier <michael@paquier.xyz>
Fix more strcmp() calls using boolean-like comparisons for result checks Such calls can confuse the reader as strcmp() uses an integer as result. The places patched here have been spotted by Thomas Munro, David Rowley and myself. Author: Michael Paquier Reviewed-by: David Rowley Discussion: https://postgr.es/m/20190411021946.GG2728@paquier.xyz
Files
| Path | Change | +/− |
|---|---|---|
| contrib/spi/refint.c | modified | +6 −3 |
| src/backend/commands/lockcmds.c | modified | +2 −1 |
| src/backend/tsearch/spell.c | modified | +4 −4 |
| src/test/modules/test_rls_hooks/test_rls_hooks.c | modified | +4 −4 |
Discussion
- Suspicious strcmp() in src/backend/parser/parse_expr.c 13 messages · 2019-04-10 → 2019-04-12