Reduce an unnecessary O(N^3) loop in lexer.
Andrew Gierth <rhodiumtoad@postgresql.org>
Reduce an unnecessary O(N^3) loop in lexer. The lexer's handling of operators contained an O(N^3) hazard when dealing with long strings of + or - characters; it seems hard to prevent this case from being O(N^2), but the additional N multiplier was not needed. Backpatch all the way since this has been there since 7.x, and it presents at least a mild hazard in that trying to do Bind, PREPARE or EXPLAIN on a hostile query could take excessive time (without honouring cancels or timeouts) even if the query was never executed.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/parser/scan.l | modified | +20 −7 |
| src/fe_utils/psqlscan.l | modified | +20 −7 |
| src/interfaces/ecpg/preproc/pgc.l | modified | +21 −8 |