Code review for escape-strings patch. Sync psql and plpgsql lexers
Tom Lane <tgl@sss.pgh.pa.us>
Code review for escape-strings patch. Sync psql and plpgsql lexers with main, avoid using a SQL-defined SQLSTATE for what is most definitely not a SQL-compatible error condition, fix documentation omissions, adhere to message style guidelines, don't use two GUC_REPORT variables when one is sufficient. Nothing done about pg_dump issues.
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/errcodes.sgml | modified | +6 −1 |
| doc/src/sgml/libpq.sgml | modified | +16 −5 |
| doc/src/sgml/protocol.sgml | modified | +7 −4 |
| doc/src/sgml/runtime.sgml | modified | +15 −26 |
| doc/src/sgml/syntax.sgml | modified | +4 −4 |
| src/backend/parser/scan.l | modified | +38 −18 |
| src/backend/utils/misc/guc.c | modified | +3 −14 |
| src/bin/psql/psqlscan.l | modified | +11 −6 |
| src/include/utils/errcodes.h | modified | +2 −1 |
| src/pl/plpgsql/src/scan.l | modified | +32 −3 |