Release PQconninfoOptions array in GetDbnameFromConnectionOptions().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: d37e0d0c50ee560fa2e7dc2a4dc904a885957985
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2024-03-24T16:31:05Z
Releases: 17.0
Release PQconninfoOptions array in GetDbnameFromConnectionOptions().

It wasn't getting freed in one code path, which Coverity identified as
a resource leak.  It's probably of little consequence, but re-ordering
the code into the correct sequence is no more work than dismissing the
complaint.  Minor oversight in commit a145f424d.

While here, improve the unreasonably clunky coding of
FindDbnameInConnParams: use of an output parameter is unnecessary
and prone to uninitialized-variable problems.

Files

PathChange+/−
src/bin/pg_basebackup/streamutil.c modified +14 −15