Fix some error message inconsistencies

Michael Paquier <michael@paquier.xyz>

Commit: d32e17160971b2c2c0f6a0261cedeab87d59f93a
Author: Michael Paquier <michael@paquier.xyz>
Date: 2026-02-06T06:38:29Z
Releases: 14.21
Fix some error message inconsistencies

These errors are very unlikely going to show up, but in the event that
they happen, some incorrect information would have been provided:
- In pg_rewind, a stat() failure was reported as an open() failure.
- In pg_combinebackup, a check for the new directory of a tablespace
mapping was referred as the old directory.
- In pg_combinebackup, a failure in reading a source file when copying
blocks referred to the destination file.

The changes for pg_combinebackup affect v17 and newer versions.  For
pg_rewind, all the stable branches are affected.

Author: Man Zeng <zengman@halodbtech.com>
Discussion: https://postgr.es/m/tencent_1EE1430B1E6C18A663B8990F@qq.com
Backpatch-through: 14

Files

PathChange+/−
src/bin/pg_rewind/file_ops.c modified +1 −1

Discussion