Horton

Proper object locking for GRANT/REVOKE

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: d31bbfb6590e586f731345960311861d5eb4c23f
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2024-11-15T10:03:48Z
Releases: 18.0 
Proper object locking for GRANT/REVOKE

Refactor objectNamesToOids() to use get_object_address() internally if
possible.  Not only does this save a lot of code, it also allows us to
use the object locking provided by get_object_address() for
GRANT/REVOKE.  There was previously a code comment that complained
about the lack of locking in objectNamesToOids(), which is now fixed.

The check in ExecGrant_Type_check() is obsolete because
get_object_address_type() already does the same check.

Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/bf72b82c-124d-4efa-a484-bb928e9494e4@eisentraut.org

Files

PathChange+/−
src/backend/catalog/aclchk.c modified +38 −119
src/test/isolation/expected/intra-grant-inplace.out modified +1 −1

Discussion