Fix Perl coding error in msvc build system

Peter Eisentraut <peter_e@gmx.net>

Commit: d30292b8c45a1d909ff7d84bd6787c8827134fc3
Author: Peter Eisentraut <peter_e@gmx.net>
Date: 2015-02-19T01:24:30Z
Releases: 9.5.0
Fix Perl coding error in msvc build system

Code like

    open(P, "cl /? 2>&1 |") || die "cl command not found";

does not actually catch any errors, because the exit status of the
command before the pipe is ignored.  The fix is to look at $?.

This also gave the opportunity to clean up the logic of this code a bit.

Files

PathChange+/−
src/tools/msvc/Solution.pm modified +3 −11
src/tools/msvc/VSObjectFactory.pm modified +7 −21