Fix Perl coding error in msvc build system
Peter Eisentraut <peter_e@gmx.net>
Fix Perl coding error in msvc build system
Code like
open(P, "cl /? 2>&1 |") || die "cl command not found";
does not actually catch any errors, because the exit status of the
command before the pipe is ignored. The fix is to look at $?.
This also gave the opportunity to clean up the logic of this code a bit.
Files
| Path | Change | +/− |
|---|---|---|
| src/tools/msvc/Solution.pm | modified | +3 −11 |
| src/tools/msvc/VSObjectFactory.pm | modified | +7 −21 |