Horton

Remove configure probe for fdatasync.

Thomas Munro <tmunro@postgresql.org>

View on postgr.es
Commit: d2e150831af85fd30742f551a497db6639d91d0b
Author: Thomas Munro <tmunro@postgresql.org>
Date: 2022-08-05T04:37:38Z
Releases: 16.0 
Remove configure probe for fdatasync.

fdatasync() is in SUSv2, and all targeted Unix systems have it.  We have
a replacement function for Windows.

We retain the probe for the function declaration, which allows us to
supply the mysteriously missing declaration for macOS, and also for
Windows.  No need to keep a HAVE_FDATASYNC macro around.

Also rename src/port/fdatasync.c to win32fdatasync.c since it's only for
Windows.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com
Discussion: https://postgr.es/m/CA%2BhUKGJZJVO%3DiX%2Beb-PXi2_XS9ZRqnn_4URh0NUQOwt6-_51xQ%40mail.gmail.com

Files

PathChange+/−
configure modified +7 −7
configure.ac modified +1 −2
src/backend/access/transam/xlog.c modified +0 −4
src/backend/storage/file/fd.c modified +0 −8
src/bin/pg_test_fsync/pg_test_fsync.c modified +0 −4
src/include/access/xlogdefs.h modified +2 −5
src/include/pg_config.h.in modified +0 −3
src/include/port/freebsd.h modified +0 −2
src/include/port/win32_port.h modified +0 −8
src/port/win32fdatasync.c (from src/port/fdatasync.c) renamed +3 −3
src/tools/msvc/Mkvcbuild.pm modified +2 −1
src/tools/msvc/Solution.pm modified +0 −1

Discussion