Horton

Fix the incorrect assertion introduced in commit 7f13ac8123.

Amit Kapila <akapila@postgresql.org>

View on postgr.es
Commit: d2169c998553a6945fd51b8a1e5e9e1384283fdd
Author: Amit Kapila <akapila@postgresql.org>
Date: 2022-08-29T02:40:10Z
Releases: 16.0 
Fix the incorrect assertion introduced in commit 7f13ac8123.

It has been incorrectly assumed in commit 7f13ac8123 that we can either
purge all or none in the catalog modifying xids list retrieved from a
serialized snapshot. It is quite possible that some of the xids in that
array are old enough to be pruned but not others.

As per buildfarm

Author: Amit Kapila and Masahiko Sawada
Reviwed-by: Masahiko Sawada
Discussion: https://postgr.es/m/CAA4eK1LBtv6ayE+TvCcPmC-xse=DVg=SmbyQD1nv_AaqcpUJEg@mail.gmail.com

Files

PathChange+/−
contrib/test_decoding/expected/catalog_change_snapshot.out modified +55 −1
contrib/test_decoding/specs/catalog_change_snapshot.spec modified +20 −0
src/backend/replication/logical/snapbuild.c modified +31 −19

Discussion