Robustify tuplesort's free_sort_tuple function

David Rowley <drowley@postgresql.org>

Commit: d0e44bae4923cebe08fd03f8ac6cb42757eec480
Author: David Rowley <drowley@postgresql.org>
Date: 2021-07-13T01:32:10Z
Releases: 9.6.23
Robustify tuplesort's free_sort_tuple function

41469253e went to the trouble of removing a theoretical bug from
free_sort_tuple by checking if the tuple was NULL before freeing it. Let's
make this a little more robust by also setting the tuple to NULL so that
should we be called again we won't end up doing a pfree on the already
pfree'd tuple. Per advice from Tom Lane.

Discussion: https://postgr.es/m/3188192.1626136953@sss.pgh.pa.us
Backpatch-through: 9.6, same as 41469253e

Files

PathChange+/−
src/backend/utils/sort/tuplesort.c modified +1 −0

Discussion

Cited messages not in the archive: 3188192.1626136953@sss.pgh.pa.us