Horton

Remove wal_sync_method=fsync_writethrough on Windows.

Thomas Munro <tmunro@postgresql.org>

View on postgr.es
Commit: d0c28601efaa8b04f11a19506f3371bba8438acc
Author: Thomas Munro <tmunro@postgresql.org>
Date: 2023-07-14T00:30:13Z
Releases: 17.0 
Remove wal_sync_method=fsync_writethrough on Windows.

The "fsync" level already flushes drive write caches on Windows (as does
"fdatasync"), so it only confuses matters to have an apparently higher
level that isn't actually different at all.

That leaves "fsync_writethrough" only for macOS, where it actually does
something different.

Reviewed-by: Magnus Hagander <magnus@hagander.net>
Discussion: https://postgr.es/m/CA%2BhUKGJ2CG2SouPv2mca2WCTOJxYumvBARRcKPraFMB6GSEMcA%40mail.gmail.com

Files

PathChange+/−
doc/src/sgml/wal.sgml modified +2 −3
src/backend/storage/file/fd.c modified +2 −4
src/bin/pg_test_fsync/pg_test_fsync.c modified +1 −3
src/include/port/win32_port.h modified +0 −8

Documentation touched

Discussion