Horton

Check slot->restart_lsn validity in a few more places

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: d0abe78d84274cc203f3d117b8006dc2164ca31a
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2020-04-29T00:39:04Z
Releases: 13.0 
Check slot->restart_lsn validity in a few more places

Lack of these checks could cause visible misbehavior, including
assertion failures.  This was missed in commit c6550776394e, whereby
restart_lsn becomes invalid when the size limit is exceeded.

Also reword some existing error messages, and add errdetail(), so that
the reported errors all match in spirit.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/20200408.093710.447591748588426656.horikyota.ntt@gmail.com

Files

PathChange+/−
contrib/test_decoding/expected/slot.out modified +2 −1
src/backend/replication/logical/logicalfuncs.c modified +13 −0
src/backend/replication/slotfuncs.c modified +3 −1
src/backend/replication/walsender.c modified +13 −1

Discussion