nbtree: Allocate new pages in separate function.
Peter Geoghegan <pg@bowt.ie>
nbtree: Allocate new pages in separate function. Split nbtree's _bt_getbuf function is two: code that read locks or write locks existing pages remains in _bt_getbuf, while code that deals with allocating new pages is moved to a new, dedicated function called _bt_allocbuf. This simplifies most _bt_getbuf callers, since it is no longer necessary for them to pass a heaprel argument. Many of the changes to nbtree from commit 61b313e4 can be reverted. This minimizes the divergence between HEAD/PostgreSQL 16 and earlier release branches. _bt_allocbuf replaces the previous nbtree idiom of passing P_NEW to _bt_getbuf. There are only 3 affected call sites, all of which continue to pass a heaprel for recovery conflict purposes. Note that nbtree's use of P_NEW was superficial; nbtree never actually relied on the P_NEW code paths in bufmgr.c, so this change is strictly mechanical. GiST already took the same approach; it has a dedicated function for allocating new pages called gistNewBuffer(). That factor allowed commit 61b313e4 to make much more targeted changes to GiST. Author: Peter Geoghegan <pg@bowt.ie> Reviewed-By: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://postgr.es/m/CAH2-Wz=8Z9qY58bjm_7TAHgtW6RzZ5Ke62q5emdCEy9BAzwhmg@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| contrib/amcheck/verify_nbtree.c | modified | +7 −8 |
| src/backend/access/heap/heapam_handler.c | modified | +2 −7 |
| src/backend/access/nbtree/nbtinsert.c | modified | +28 −20 |
| src/backend/access/nbtree/nbtpage.c | modified | +182 −172 |
| src/backend/access/nbtree/nbtree.c | modified | +2 −2 |
| src/backend/access/nbtree/nbtsearch.c | modified | +26 −22 |
| src/backend/access/nbtree/nbtsort.c | modified | +1 −1 |
| src/backend/access/nbtree/nbtutils.c | modified | +3 −4 |
| src/backend/optimizer/util/plancat.c | modified | +1 −1 |
| src/backend/utils/sort/tuplesortvariants.c | modified | +2 −3 |
| src/include/access/nbtree.h | modified | +14 −12 |
| src/include/utils/tuplesort.h | modified | +1 −3 |
Discussion
- Cleaning up nbtree after logical decoding on standby work 24 messages · 2023-05-26 → 2023-06-10