In pg_log_generic(), be more paranoid about preserving errno.
Tom Lane <tgl@sss.pgh.pa.us>
In pg_log_generic(), be more paranoid about preserving errno. This code failed to account for the possibility that malloc() would change errno, resulting in wrong output for %m, not to mention the possibility of message truncation. Such a change is obviously expected when malloc fails, but there's reason to fear that on some platforms even a successful malloc call can modify errno. Discussion: https://postgr.es/m/2576.1527382833@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/common/logging.c | modified | +2 −0 |
Discussion
- Allowing printf("%m") only where it actually works 50 messages · 2018-05-21 → 2018-10-09